Mesh loaders kevin #894
Mesh loaders kevin #894
Conversation
| auto switch_vec = [](hlsl::uint32_t4 val1, hlsl::uint32_t4 val2, hlsl::bool4 mask) | ||
| { | ||
| hlsl::uint32_t4 retval; | ||
| retval.x = mask.x ? val2.x : val1.x; | ||
| retval.y = mask.y ? val2.y : val1.y; | ||
| retval.z = mask.z ? val2.z : val1.z; | ||
| retval.w = mask.w ? val2.w : val1.w; | ||
| return retval; | ||
| }; |
There was a problem hiding this comment.
dont we have a mix/select in our intrinsics.hlsl for this ?
There was a problem hiding this comment.
Mix only work for floating point. there is no select
There was a problem hiding this comment.
@keptsecret shouldn't our mix(vector<T,N>,vector<T,N>,vector<bool,N>) work with any T?
There was a problem hiding this comment.
It should. Doesn't have the new changes on the hlsl_bxdf branch, but master right now mix(vector<T,N>,vector<T,N>,vector<bool,N>) should be routed to the looped version that uses mix(T, T, bool)
|
Aisde from my nitpicks, I assume everything works? |
|
@kevyuu was about to merge but the CI checks are failing, please check the logs and see whats wrong. |
|
btw what's the companion examples/tests PR ? |
|
Implement extra geometries